Monthly Bug Scrub Notes June 2018

Issues Summary

  • May Status: 4 resolved, 7 moved to June
  • Discussed: 24
  • Closed: 2
  • Raised: 1
  • Participants: 2

June 2018 Milestone on GitHub

May 2018 Recap: Resolved Issue & Pull Request Notes

Add email notification when student cancels a subscription

Iss. #528

  • Resolved by Thomas
  • Released in version 3.17.8

Unpredictable JS load order creates undefined function type of errors

Iss. #520

  • Resolved by Saurabh
  • Released in version 3.17.8

Debug mode support for assets

PR. #484

  • Resolved by Saurabh
  • Released in version 3.17.8

May 2018 Recap: Unresolved Issue & Pull Request Notes

Optimize scripts/styles for non LifterLMS pages

Iss. #145

  • Global window.llms via inline enqueue still problematic
  • Break up the asset enqueue method into multiple methods since the method
  • Saurabh will continue to work on this along with bulk enrollment
  • Assigned to June 2018 Milestone

if all fields are disabled for checkout it looks weird when a user is already logged in because the box is empty

Iss. 235

  • No updates from May
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

voucher screen on admin panel needs color scheme update

Iss. 239

  • No updates from May
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

add current item classes to catalogs

Iss. 257

  • Clarified language in issue
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

prereq and dependency checks on post trash

Iss. 263

  • This is a large issue interrelated to many more recent discussions around core enhancements
  • This issue should be broken into smaller more digestable issues based off issue checklist
  • There’s some outstanding questions around how certain actions should be handled. EG: what should happen to student completion when a lesson is removed from a course?
  • Assigned to June 2018 Milestone

Free lesson stamp should not be visible when course is available to enrolled student or member who has access

Iss. 253

  • Saurabh spent time in May and has potential solution
  • Assigned to Saurabh for implementation
  • Assigned to June 2018 Milestone

Self-cancelled subscriptions should unenroll at the end of the prepaid period not immediately

Iss. 490 & PR #569

  • Initial issue resolved
  • Before deployment must resolve new issues related to reactivating a (pending-)cancelled order
  • Thomas to complete in June
  • Assigned to June 2018 Milestone

Issue & Pull Request Notes

if a course has a free access plan course enrollment restrictions are being ignored

Iss. #266

  • We’re not sure if this is still an issue or what the issue is stating
  • Assigned to Thomas to investigate and possibly close as non-issue
  • Assigned to June 2018 Milestone

Hook to disable/remove all about Payments/Shop/Price

Iss. #267

  • Available for assignment comment if you’d like to work on this
  • Assigned to Future Milestone

delayed engagements may still fire after engagement has been deleted

Iss. #290

  • Clarified issue language and solution
  • Available for assignment comment if you’d like to work on this
  • Assigned to Future Milestone

potential plugin conflict with Post Type Switcher plugin

Iss. #271

  • Noted that this issue is potentially related to existing solutions in LifterLMS
  • Raised new issue with potential solution for greater general plugin compatibility
  • Assigned to Future Milestone

reporting screen shows weird dates when only one day worth of data is displayed #302

https://github.com/gocodebox/lifterlms/issues/302

  • Will be resolved in combination with core information tracking improvements
  • Assigned to Future Milestone

WC Account Edit redirect to LifterLMS account page

(Iss. #309)[https://github.com/gocodebox/lifterlms/issues/309]

  • Unable to recreate during meeting
  • Closed issue

notification center

Iss. #318

  • Assigned to Future Milestone

inefficient calls to get_the_post_thumbnail in various templates

Iss. #322

  • Assigned to Saurabh
  • Assigned to June 2018 Milestone

add WordPress filters to default views & periods on reporting screens

Iss. #323

  • clarified language of issue
  • Assigned to Thomas
  • Assigned to June 2018 Milestone

Inaccurate reposition during notification dismissals

Iss. #325

  • Still need help reliably recreating
  • Assigned to Future Milestone

Order / Transaction Status Notifications

Iss. #328

  • Assigned to Thomas to work on with pending-cancellation features
  • Assigned to June 2018 Milestone

Reporting student last activity reports the enrollment updated date instead of an actual date of last activity

Iss. #332

  • Will be resolved in combination with core information tracking improvements
  • Assigned to Future Milestone

create a manual interface for recording misc order notes from the admin panel

Iss. #334

  • Assigned to Future Milestone

(NEW) CRUD access plans via AJAX call rather than during post save form submission

Iss. #576

  • Assigned to Future Milestone

 

Want to Get Involved?

This month we’ve identified 6 issues as good bugs for first-time contributors to tackle. Check them out and leave a note if you want to get started. If you’re not sure how to get started let us know and we’ll help you get moving!

You can join us for the next scrub on July, 3, 2018. Check the Events Calendar for more information.

Upcoming Bug Scrub June 2018

The next LifterLMS Core Bug Scrub will take place on Tuesday, June 5, 2018 at 9am PST.

This month we’ll see how we did on issues assigned during May’s scrub and continue working through the LifterLMS core issue backlog. Each issue will be briefly discussed and clarified and then either assigned or closed.

This hour-long session is open to anyone interested in attending. Come prepared to pick up a task, provide feedback on raised issues, or simply watch and listen.

Note: This meeting is not a forum for raising new issues or feature requests!

Checkout the Events Calendar for more details on the June Scrub (and other upcoming events) or join us via Zoom. The video conference will open a few minutes prior to the start of the meeting.

LifterLMS Version 3.18.2

  • Improved integrations settings screen to allow each integration to have it’s own settings tab (page) with only its own settings
  • Allow programmatic access to notification content when notification views are accessed via filters
  • Fixed issue causind subscription cancellation notifications to be sent to admins when new orders were created
  • Fixed warning message displayed prior to membership bulk enrollment
  • Fixed multibyte character encoding issue encountered during certificate exports

LifterLMS MailChimp Version 3.0.0

  • Removes LifterLMS 2.x compatibility, raising the minimum required LifterLMS version to 3.8.0
  • “Confirmation Emails” subscription setting is now enabled by default when installing LifterLMS Add-on
  • Adds a checkbox to enrollment, registration, and checkout forms allowing users to explicitly consent to receive emails
  • To accommodate GDPR compliance, sequences and tags will only be applied to users who have explicitly consented to receive emails.
  • Users who have previously consented to receive emails may opt out via a checkbox on the edit account tab of the student dashboard
  • New options have been added to allow customization of the consent and unsubscribe messages
  • Added Privacy Policy Suggested content linking to the MailChimp Privacy Policy. Relies on WP 4.9.6.
  • Renamed plugin options to be consistent with other LifterLMS integration classes. Preexisting options will be renamed automatically upon plugin upgrade.
  • Moved ajax functions to their own class
  • Removed function LLMS_MailChimp()->get_groups(), use LLMS_MailChimp()->get_intergration()->get_groups() instead
  • Removed function LLMS_MailChimp()->get_lists(), use LLMS_MailChimp()->get_intergration()->get_lists() instead

LifterLMS MailChimp Version 3.0.0

  • Removes LifterLMS 2.x compatibility, raising the minimum required LifterLMS version to 3.8.0
  • “Confirmation Emails” subscription setting is now enabled by default when installing LifterLMS Add-on
  • Adds a checkbox to enrollment, registration, and checkout forms allowing users to explicitly consent to receive emails
  • To accommodate GDPR compliance, sequences and tags will only be applied to users who have explicitly consented to receive emails.
  • Users who have previously consented to receive emails may opt out via a checkbox on the edit account tab of the student dashboard
  • New options have been added to allow customization of the consent and unsubscribe messages
  • Added Privacy Policy Suggested content linking to the ConvertKit Privacy Policy. Relies on WP 4.9.6.
  • Renamed plugin options to be consistent with other LifterLMS integration classes. Preexisting options will be renamed automatically upon plugin upgrade.
  • Moved ajax functions to their own class
  • Removed function LLMS_MailChimp()->get_groups(), use LLMS_MailChimp()->get_intergration()->get_groups() instead
  • Removed function LLMS_MailChimp()->get_lists(), use LLMS_MailChimp()->get_intergration()->get_lists() instead

LifterLMS ConvertKit Version 2.0.0

  • Removes LifterLMS 2.x compatibility, raising the minimum required LifterLMS version to 3.8.0
  • Adds a checkbox to enrollment, registration, and checkout forms allowing users to explicitly consent to receive emails
  • To accommodate GDPR compliance, sequences and tags will only be applied to users who have explicitly consented to receive emails.
  • Users who have previously consented to receive emails may opt out via a checkbox on the edit account tab of the student dashboard
  • New options have been added to allow customization of the consent and unsubscribe messages
  • Added Privacy Policy Suggested content linking to the ConvertKit Privacy Policy. Relies on WP 4.9.6.
  • In addition to an API Key, a Secret Key must also be obtained to API methods to unsubscribe users
  • Class LLMS_Settings_Integrations_ConvertKit has been replaced by LLMS_Integration_ConvertKit which is an integration child accessible programattically via LLMS()->integrations()->get( 'convertkit' )
  • Renamed plugin options to be consistent with other LifterLMS integration classes. Preexisting options will be renamed automatically upon plugin upgrade.

LifterLMS Social Learning Version 1.2.0

Privacy & GDPR Compliance Tools
  • Added suggested Privacy Policy language outlining information gathered by a default LifterLMS Social Learning site
  • During a WordPress Personal Data Export request the following LifterLMS Social Learning information will be added to the export

  • All profile fields (website url, social profile urls, site handle)

  • All timeline stories
  • All timeline story replies
  • User avatar & profile cover image

  • During a WordPress Personal Data Erasure request the following LifterLMS Social Learning information will be erased

  • All profile fields (website url, social profile urls, site handle)

  • All timeline stories
  • All timeline story replies

  • All of the above relies on features available in WordPress core 4.9.6

Updates
  • Added RTL language support
  • Tested up to WordPress 4.9.6
Bug Fixes
  • Fixed issue preventing instructor story browsing from functioning with LifterLMS Core 3.17.0 and later