Bug Scrub

Monthly Bug Scrub Notes June 2018

Issues Summary

  • May Status: 4 resolved, 7 moved to June
  • Discussed: 24
  • Closed: 2
  • Raised: 1
  • Participants: 2

June 2018 Milestone on GitHub

May 2018 Recap: Resolved Issue & Pull Request Notes

Add email notification when student cancels a subscription

Iss. #528

  • Resolved by Thomas
  • Released in version 3.17.8

Unpredictable JS load order creates undefined function type of errors

Iss. #520

  • Resolved by Saurabh
  • Released in version 3.17.8

Debug mode support for assets

PR. #484

  • Resolved by Saurabh
  • Released in version 3.17.8

May 2018 Recap: Unresolved Issue & Pull Request Notes

Optimize scripts/styles for non LifterLMS pages

Iss. #145

  • Global window.llms via inline enqueue still problematic
  • Break up the asset enqueue method into multiple methods since the method
  • Saurabh will continue to work on this along with bulk enrollment
  • Assigned to June 2018 Milestone

if all fields are disabled for checkout it looks weird when a user is already logged in because the box is empty

Iss. 235

  • No updates from May
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

voucher screen on admin panel needs color scheme update

Iss. 239

  • No updates from May
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

add current item classes to catalogs

Iss. 257

  • Clarified language in issue
  • Available for assignment comment if you’d like to work on this
  • Assigned to June 2018 Milestone

prereq and dependency checks on post trash

Iss. 263

  • This is a large issue interrelated to many more recent discussions around core enhancements
  • This issue should be broken into smaller more digestable issues based off issue checklist
  • There’s some outstanding questions around how certain actions should be handled. EG: what should happen to student completion when a lesson is removed from a course?
  • Assigned to June 2018 Milestone

Free lesson stamp should not be visible when course is available to enrolled student or member who has access

Iss. 253

  • Saurabh spent time in May and has potential solution
  • Assigned to Saurabh for implementation
  • Assigned to June 2018 Milestone

Self-cancelled subscriptions should unenroll at the end of the prepaid period not immediately

Iss. 490 & PR #569

  • Initial issue resolved
  • Before deployment must resolve new issues related to reactivating a (pending-)cancelled order
  • Thomas to complete in June
  • Assigned to June 2018 Milestone

Issue & Pull Request Notes

if a course has a free access plan course enrollment restrictions are being ignored

Iss. #266

  • We’re not sure if this is still an issue or what the issue is stating
  • Assigned to Thomas to investigate and possibly close as non-issue
  • Assigned to June 2018 Milestone

Hook to disable/remove all about Payments/Shop/Price

Iss. #267

  • Available for assignment comment if you’d like to work on this
  • Assigned to Future Milestone

delayed engagements may still fire after engagement has been deleted

Iss. #290

  • Clarified issue language and solution
  • Available for assignment comment if you’d like to work on this
  • Assigned to Future Milestone

potential plugin conflict with Post Type Switcher plugin

Iss. #271

  • Noted that this issue is potentially related to existing solutions in LifterLMS
  • Raised new issue with potential solution for greater general plugin compatibility
  • Assigned to Future Milestone

reporting screen shows weird dates when only one day worth of data is displayed #302

https://github.com/gocodebox/lifterlms/issues/302

  • Will be resolved in combination with core information tracking improvements
  • Assigned to Future Milestone

WC Account Edit redirect to LifterLMS account page

(Iss. #309)[https://github.com/gocodebox/lifterlms/issues/309]

  • Unable to recreate during meeting
  • Closed issue

notification center

Iss. #318

  • Assigned to Future Milestone

inefficient calls to get_the_post_thumbnail in various templates

Iss. #322

  • Assigned to Saurabh
  • Assigned to June 2018 Milestone

add WordPress filters to default views & periods on reporting screens

Iss. #323

  • clarified language of issue
  • Assigned to Thomas
  • Assigned to June 2018 Milestone

Inaccurate reposition during notification dismissals

Iss. #325

  • Still need help reliably recreating
  • Assigned to Future Milestone

Order / Transaction Status Notifications

Iss. #328

  • Assigned to Thomas to work on with pending-cancellation features
  • Assigned to June 2018 Milestone

Reporting student last activity reports the enrollment updated date instead of an actual date of last activity

Iss. #332

  • Will be resolved in combination with core information tracking improvements
  • Assigned to Future Milestone

create a manual interface for recording misc order notes from the admin panel

Iss. #334

  • Assigned to Future Milestone

(NEW) CRUD access plans via AJAX call rather than during post save form submission

Iss. #576

  • Assigned to Future Milestone

 

Want to Get Involved?

This month we’ve identified 6 issues as good bugs for first-time contributors to tackle. Check them out and leave a note if you want to get started. If you’re not sure how to get started let us know and we’ll help you get moving!

You can join us for the next scrub on July, 3, 2018. Check the Events Calendar for more information.

Upcoming Bug Scrub June 2018

The next LifterLMS Core Bug Scrub will take place on Tuesday, June 5, 2018 at 9am PST.

This month we’ll see how we did on issues assigned during May’s scrub and continue working through the LifterLMS core issue backlog. Each issue will be briefly discussed and clarified and then either assigned or closed.

This hour-long session is open to anyone interested in attending. Come prepared to pick up a task, provide feedback on raised issues, or simply watch and listen.

Note: This meeting is not a forum for raising new issues or feature requests!

Checkout the Events Calendar for more details on the June Scrub (and other upcoming events) or join us via Zoom. The video conference will open a few minutes prior to the start of the meeting.

Monthly Bug Scrub Notes May 2018

Issues Summary

  • Discussed: 13
  • Closed: 2
  • Raised: 2
  • Participants: 2

May 2018 Milestone on GitHub

Issue & Pull Request Notes

JS & CSS Assets, Dependencies, & Performance

Iss. #146 & Iss. #520 (& Related PR #484)

  • JS (and CSS) dependencies must be defined and improved
  • Scripts should not load on non LifterLMS Pages except when a LifterLMS shortcode or widget exists
  • JS errors resulting from improperly defined JS dependencies
  • Assigned to Thomas to review & merge #484
  • Assigned to Saurabh for implementation
  • Assigned to May 2018 Milestone

BuddyPress Enhancements

Iss. #164

  • Feature enhancements clarified
  • Moved to Future Milestone
  • Unassigned

Metaboxes Cleanup and Gutenberg Prep

Iss. #191 & Iss. #244

  • Finalize cleanup from LifterLMS 2.x to 3.x metabox transitions
  • Identify updates required for Gutenberg forward compatibility
  • #244 closed as duplicate of #191
  • Assigned to Saurabh (who will recruit additional contributors for Gutenberg research)

Conflict with Contact Form 7

Iss. #223

  • Reported in 2016 & never reproduced
  • Closed as wont fix

Checkout Fields UI for Logged when Checkout Fields Disabled

Iss. #235

  • Billing Info area on checkout / enrollment is blank for logged in users when all registration fields are disabled
  • Unassigned & help wanted

Vouchers Admin Screen UI Update

Iss. #239

  • CSS / SCSS color scheme updates required
  • Unassigned & help wanted

Free Lesson Stamp UI Issues

Iss. #253

  • “FREE” stamp on lesson syllabus doesn’t make sense to display to users who already have access to the course content
  • Clarified issue language & added potential solutions
  • Unassigned & help wanted

Add Current Item classes to WP Nav menus for catalogs

Iss. #257

  • May not still be an issue (needs some better reproduction steps)
  • Ensure themes can control the current menu item highlight on nav menus when viewing course / membership catalogs
  • Unassigned & help wanted

Prerequisite Checks on Post Trash

Iss. #263

  • Clarified language
  • Added additional conditions to check
  • Discussed possible strategies and solutions
  • Unassigned

(NEW) Course Level Drip & Prereq Settings

Iss. #521

  • Raised as a possible helper solution to #263
  • Unassigned and added to future milestone

(New) Course “Elements”

Iss. #522

  • Notes on ongoing refactoring / functionality expansion discussion to increase the flexibility of courses
  • Unassigned and added to future milestone

Notes

  • Created additional labels to be added to issues to help identify the languages required to resolve the issue: PHP, Javascript, CSS/SCSS
  • Join us for our next scrub on Tuesday, June 5, 2018, 9am – 10am PST