Core

Monthly Bug Scrub Notes May 2018

Issues Summary

  • Discussed: 13
  • Closed: 2
  • Raised: 2
  • Participants: 2

May 2018 Milestone on GitHub

Issue & Pull Request Notes

JS & CSS Assets, Dependencies, & Performance

Iss. #146 & Iss. #520 (& Related PR #484)

  • JS (and CSS) dependencies must be defined and improved
  • Scripts should not load on non LifterLMS Pages except when a LifterLMS shortcode or widget exists
  • JS errors resulting from improperly defined JS dependencies
  • Assigned to Thomas to review & merge #484
  • Assigned to Saurabh for implementation
  • Assigned to May 2018 Milestone

BuddyPress Enhancements

Iss. #164

  • Feature enhancements clarified
  • Moved to Future Milestone
  • Unassigned

Metaboxes Cleanup and Gutenberg Prep

Iss. #191 & Iss. #244

  • Finalize cleanup from LifterLMS 2.x to 3.x metabox transitions
  • Identify updates required for Gutenberg forward compatibility
  • #244 closed as duplicate of #191
  • Assigned to Saurabh (who will recruit additional contributors for Gutenberg research)

Conflict with Contact Form 7

Iss. #223

  • Reported in 2016 & never reproduced
  • Closed as wont fix

Checkout Fields UI for Logged when Checkout Fields Disabled

Iss. #235

  • Billing Info area on checkout / enrollment is blank for logged in users when all registration fields are disabled
  • Unassigned & help wanted

Vouchers Admin Screen UI Update

Iss. #239

  • CSS / SCSS color scheme updates required
  • Unassigned & help wanted

Free Lesson Stamp UI Issues

Iss. #253

  • “FREE” stamp on lesson syllabus doesn’t make sense to display to users who already have access to the course content
  • Clarified issue language & added potential solutions
  • Unassigned & help wanted

Add Current Item classes to WP Nav menus for catalogs

Iss. #257

  • May not still be an issue (needs some better reproduction steps)
  • Ensure themes can control the current menu item highlight on nav menus when viewing course / membership catalogs
  • Unassigned & help wanted

Prerequisite Checks on Post Trash

Iss. #263

  • Clarified language
  • Added additional conditions to check
  • Discussed possible strategies and solutions
  • Unassigned

(NEW) Course Level Drip & Prereq Settings

Iss. #521

  • Raised as a possible helper solution to #263
  • Unassigned and added to future milestone

(New) Course “Elements”

Iss. #522

  • Notes on ongoing refactoring / functionality expansion discussion to increase the flexibility of courses
  • Unassigned and added to future milestone

Notes

  • Created additional labels to be added to issues to help identify the languages required to resolve the issue: PHP, Javascript, CSS/SCSS
  • Join us for our next scrub on Tuesday, June 5, 2018, 9am – 10am PST

 

 

LifterLMS Version 3.17.7

  • Fix issue preventing assignments passing grade requirement from saving properly
  • Fix issue preventing builder toggle switches from properly saving some switch field data
  • Fix with “Launch Builder” button causing it to extend outside the bounds of its container
  • Fix issue with builder radio select fields during view rerenders
  • Course Outline shortcode (and widget) now retrieve parent course of the current page more consistently with other shortcodes
  • Added ability to filter which custom post types which can be children of a course (allows course shortcodes & widgets to be used in assignment sidebars of custom content areas)

LifterLMS Version 3.17.6

  • Updated language on recurring orders with no expiration settings. Orders no longer say “Lifetime Access” and instead output no expiration information
  • Quiz editor on builder updated to be consistent visually and functionally to the lesson settings editor
  • Improved the builder field API to allow for radio element fields
  • Fix issue causing JS error on admin settings pages
  • Updated CSS for Certificates to be more generally compatible with theme styles when printed
  • Allow system print settings to control print layout for certificates by removing explicit landscape declarations
  • Now passing additional data to filters used to create custom columns on reporting screens
  • Remove unused JS files & Chosen JS library
  • Added filter to allow opting into alternate student dashboard order layout. Use add_filter( 'llms_sd_stacked_order_layout', '__return_true' ) to stack the payment update sidebar below the main order information. This is disabled by default.
  • Achievement and Certificate basic notifications now auto-dismiss after 10 seconds like all other basic notifications
  • Deprecated Filter llms_get_quiz_theme_settings and added backwards compatible methods to transition themes using this filter to the new custom field api. For more information see new methods at https://lifterlms.com/docs/course-builder-custom-fields-for-developers/
  • Increased default z-index on notifications to prevent notifications from being hidden behind floating / static navigation menus
Template Updates